AtlasMajorCities: Latest Release

Find NPCs in major towns and cities.

Moderators: PiDion, sheavi

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Sun Jul 04, 2010 10:53 pm

The unstable and problematic "release" file has been removed from Curse/WoWAce.

voyseys
Posts: 1
Joined: Mon Jul 05, 2010 1:11 pm

Re: AtlasMajorCities: Latest Release

Post by voyseys » Mon Jul 05, 2010 2:02 pm

The Errors are a result of two files.

in \Libs\LibBabble-NPC-Description-3.0.lua
Under enUS
["Master MageTrainer"] = "Master Mage Trainer";
should be
["Master Mage"] = "Master Mage";


["Speciality Tailoring Supplies"] = "Speciality Tailoring Supplies";
should be
["Specialty Tailoring Supplies"] = "Specialty Tailoring Supplies";


funnily enough, this is correct in the zhTW. x:)

in \Locale\amc_enUS.lua
AMCL["OEric"] = "Outfitter Eric".." <"..BabbleNPCDesc["Speciality Tailoring Supplies"]..">";
to
AMCL["OEric"] = "Outfitter Eric".." <"..BabbleNPCDesc["Specialty Tailoring Supplies"]..">";

I think that is all of them.

You'll have to tweak the header of libBabble-NPC-Description-3.0.lua file to get it to run.
Revision: $Rev: 8 $
to
Revision: $Rev: 9 $

and

Last updated by: $Author: arith $, $Date: 2010-06-27 13:26:26 +0000 (Sun, 27 Jun 2010) $
to
Last updated by: $Author: arith $, $Date: 2010-06-28 13:26:26 +0000 (Mon, 28 Jun 2010) $

Just to nudge it until the new version.

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Mon Jul 05, 2010 2:28 pm

oh really? I try temporary disable zhTW so it will load enUS, this is the only way I can test if enUS works fine, but with the latest SVN revision it seems to be working fine.
I will check it again tomorrow. It's bed time.

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Wed Jul 07, 2010 11:14 am

OK I see the problem, will fix it soon.

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Thu Jul 08, 2010 2:02 am

PiDion, I am sorry for quite a lot of troubles in recent revision, most of them are due to the un-matured LibBabble-NPC-Description. I think I'd better to remove the use of this library so that the addon will turn back to a more stable situation.
I know we are discussing with Andy for the possible merging and migration, but at lease we need to make the addon in a stable stage.
If you don't have any other concern, I will remove the use of this library.

User avatar
PiDion
Posts: 90
Joined: Sun Dec 31, 2006 9:06 pm
Location: Ahlen, Germany
Contact:

Re: AtlasMajorCities: Latest Release

Post by PiDion » Thu Jul 08, 2010 3:17 am

arith wrote:PiDion, I am sorry for quite a lot of troubles in recent revision, most of them are due to the un-matured LibBabble-NPC-Description. I think I'd better to remove the use of this library so that the addon will turn back to a more stable situation.
I know we are discussing with Andy for the possible merging and migration, but at lease we need to make the addon in a stable stage.
If you don't have any other concern, I will remove the use of this library.
Do as you wish, as long it stops the errors and get the version stable. When i get home (Today or tomorrow) i'm back into the addon, now i can't do anything xD
2016 a Star Reborn...

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Thu Jul 08, 2010 3:46 am

I admit that it's an approach trying to make the translation easier, but not mature.
Actually there is some more official way to at least make the Lib more stable, Shaun (voyseys) has spent some time to help on making the Lib more stable, at least for enUS/enGB now.
But even so, if the translator want to translate the LibBabble-NPC-Description, it's also not that easier since the amount of entries are still not small (around 380 entries).
Remove the use of this lib could be the safer way for now. I will do it later tonight.

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Thu Jul 08, 2010 8:37 am

The use of LibBabble-NPC-Description-3.0 has been removed, please help to test r.86 alpha build.

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Wed Jul 21, 2010 12:38 am

The latest revision looks working fine without any problem. I think we can make a new release.

User avatar
PiDion
Posts: 90
Joined: Sun Dec 31, 2006 9:06 pm
Location: Ahlen, Germany
Contact:

Re: AtlasMajorCities: Latest Release

Post by PiDion » Wed Jul 21, 2010 3:01 am

Jeah it works without errors and everything is in it (enGB client). I Tag it as v1.5.2.

Tagged & Released (curse/wowace/WowInterface/wowui.incgamers.com)
2016 a Star Reborn...

User avatar
PiDion
Posts: 90
Joined: Sun Dec 31, 2006 9:06 pm
Location: Ahlen, Germany
Contact:

Re: AtlasMajorCities: Latest Release

Post by PiDion » Wed Jul 21, 2010 8:47 am

Its funny... Someone pointed out, that atlas blocks our new release, cause Dan had build in a Version check for all plugins that were known here and atlas says a v1.5.2 is a older version than v1.5b it don't work o.o
2016 a Star Reborn...

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Wed Jul 21, 2010 9:39 am

ok, I can update the version info in Atlas, but I don't think Atlas will have a new release soon.
So a workaround is users will need to manually edit the Atlas codes, open Atlas.lua, goto line 375:

Code: Select all

{ "AtlasMajorCities", "v1.5a" },
Revise it to:

Code: Select all

{ "AtlasMajorCities", "v1.5.2" },

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Wed Jul 21, 2010 10:39 pm

It's silly, but if we renamed AMC to be v1.6.0 then I think the problem will be gone.

thetravellor
Posts: 1
Joined: Sun Jul 25, 2010 4:22 am

Re: AtlasMajorCities: Latest Release

Post by thetravellor » Mon Jul 26, 2010 5:30 am

is incompatible
Attachments
Screen shot 2010-07-25 at 3.13.15 PM.png
Screen shot 2010-07-25 at 3.13.15 PM.png (128.25 KiB) Viewed 17617 times

User avatar
arith
Posts: 910
Joined: Tue Apr 04, 2006 4:42 am
Location: Kalimdor

Re: AtlasMajorCities: Latest Release

Post by arith » Mon Jul 26, 2010 9:05 am

thetravellor wrote:is incompatible
The answer is just in above of your post.

Post Reply