Quest Links?

[thandrenn]

I've added the ability to link to quests in the next version of AtlasQuest (it's in the current SVN version for testing). When I first started I figured... well. hoped, that it was just like linking to items where I only needed the Item's ID #. This doesn't seem to be the case for quests. At least for quests that aren't in your questlog.

Here's how I have the data stored. The quest ID # isn't presently used, but will be by other things in the future. When AQ sends a quest link, it just sends the QuestLink string to the chat window. My question is, is there any other easier way of doing the quest links? Is there some function I missed somewhere? I want to know before I go through and set up the hundreds of quests in AQ (which will take a while). Thanks!

Code: Select all

...

Inst1Quest1_QuestID = "214"
Inst1Quest1_QuestLink = "|cffffff00|Hquest:214:17|h[Red Silk Bandanas]|h|r"

Inst1Quest2_QuestID = "168"
Inst1Quest2_QuestLink = "|cffffff00|Hquest:168:18|h[Collecting Memories]|h|r"

...


If anyone wants to play around with this, the SVN version (4.1.3 Alpha) has quest linking in, but is only supporting Deadmines and Wailing Caverns right now.

[Telchar]

i can only say it works for me... can't help you any further
btw great feature!

[Nihlo]

btw remember the new quest in cot with carlos

[thandrenn]

btw remember the new quest in cot with carlos

Nice Hat... is in the SVN version.

[thandrenn]

i can only say it works for me... can't help you any further
btw great feature!

When you use the Quest links on the German client are they translated? And the link itself (the text in brackets) does that get automatically translated too?

[Daviesh]

When you use the Quest links on the German client are they translated? And the link itself (the text in brackets) does that get automatically translated too?

I don't think so. All the information to make a link is there, the server is not queried for more details until you click on it (when 'quest:214:17' is passed to the server). The only check the game client does when you insert a link into the chat window is that the link is a valid quest/item/spell, I am pretty sure it doesn't do anything else for bandwidth reasons.

[yeachan]

When you use the Quest links on the German client are they translated? And the link itself (the text in brackets) does that get automatically translated too?

[quote="thandrenn
When you use the Quest links on the German client are they translated? And the link itself (the text in brackets) does that get automatically translated too?[/quote]

I have to say,it's a great work,though the link itself seen is still English.As below

And when I click the link,the tip is automatically turned into Chinese.

It's not a surprise for me,as that I have both English and Chinese client.It's just the same as that I send the link to others when I use English client.What they see is a English link name but a Chinese tip when clicked.Maybe we translator have to translate the links too.

[thandrenn]

I haven't implemented it yet, but I'm going to try to have it pull the name of the quest from the localization files. That should do the trick. Thanks for the screenshots, yeachan.

[thandrenn]

Okay, I've gone and re-worked the Quest Link code. Twice. It should use the localized quest names for the link in the chat window now. Please test and let me know if it works.

[yeachan]

Okay, I've gone and re-worked the Quest Link code. Twice. It should use the localized quest names for the link in the chat window now. Please test and let me know if it works.

No doubt,it works well,but there is still a little problem.Non-English client use the localized quest names(US client not),which brings a little problem.In Chinese client,the quest name is a few continuous Chinese characters with no blank or parenthesis.And if there is one,what you sent will be not a link.As below:


As you see,what you send out is not a link now



So,we need to remove the parenthesis from the quests just like The Test of Righteousness (Paladin)
No matter what,we translators have work to do.Take it easy ,we need work now.

[thandrenn]

Hrm. Thought I had it remove the parenthesis. I'd like to solve this problem in the code rather than having all the quest names re-translated for one minor feature. I'll have to tinker around with it more. Thanks yeachan

[thandrenn]

So are there different characters for parenthesis in the Chinese localization? Think I could add another snippet of code to just filter that out like I do for the English?

Anyone try it with the German client yet?

If you do have to remove parenthesis from the quest names for the Chinese localization, that's fine. I was planning on doing that some day anyway. But if we can leave them in for now, that'd be great.

I also changed how the data is stored in the AtlasQuest_QuestIDs.lua file. Pulling the quest name from the localization files means I don't have to store the big link strings in there anymore. Yay.

Code: Select all

Inst1Quest1_QuestID = "214"
Inst1Quest2_QuestID = "168"
Inst1Quest3_QuestID = "167"
Inst1Quest4_QuestID = "2040"
Inst1Quest5_QuestID = "166"
Inst1Quest6_QuestID = "1654"
Inst1Quest7_QuestID = "373"

AQ_214_Level = "17"
AQ_168_Level = "18"
AQ_167_Level = "20"
AQ_2040_Level = "20"
AQ_166_Level = "22"
AQ_1654_Level = "22"
AQ_373_Level = "22"


Storing the quest levels is a bit redudant at this point, and I may remove that eventually, but it seemed like a good idea to make sure the quest level being sent for the link is up to date. I've been pondering that in the future it might be good to just store Level, Attainment Level and such all in a global file rather than Localization files to cut down on duplication. I think Telchar suggested something like that a while back and I didn't like splitting up quest information into different files, but perhaps it's time for that.

[Telchar]

i only have a enGB client so all i can do is try it with loading the german file on that client with the following adjustment. you can do that as well if you want to test something quickly thandrenn, though loading the chinese file on an english client doesn't work because of the unsupported letters.

Code: Select all

if ( GetLocale() ~= "deDE" ) then

i did that and everything seems to be working fine in german. when linking a quest the text is localized (well the tooltip is english, but that's obviously because it's the english client ) and i have no problem linking a quest with parenthesis, the parenthesis part simply gets removed when i link the quest.

So are there different characters for parenthesis in the Chinese localization?

i don't know what the problem for chinese is but looking on the screenshots it seems they do not use different characters for paranthesis.

[yeachan]

I'm sorry but I did have overlooked something.In China,the parenthesis we use are SBC case (UTF-8 CODE) while you use DBC case. So,I think your code don't recognise our parenthesis.Well,your parenthesis look a little small amount the Chinese characters and that's why I use our parenthesis before.I will replace all the big parenthesis without a while.I'm sorry but it's my fault.

parenthesis in SBC case occupy a whole character and in DBC case occupy only half a character


After the replacement,it works well now.

[thandrenn]

Don't feel bad yeachan. I'm glad we got it figured out. It looks like this feature is good to go then.