[FIX] Bug Transportation Maps

Describe any bugs you've found.
Post Reply
TrAsHeR
Posts: 100
Joined: Tue Jan 09, 2007 1:53 am

[FIX] Bug Transportation Maps

Post by TrAsHeR » Fri Nov 14, 2008 2:13 pm

Hi

I don't know if it's with AtlasLoot but i have this bug : (frFR, r472)
Date: 2008-11-14 19:01:24
ID: 1
Error occured in: Global
Count: 3
Message: ..\AddOns\AtlasLoot\Core\HooksandAPI.lua line 158:
attempt to index field 'Location' (a nil value)
Debug:
[C]: ?
AtlasLoot\Core\HooksandAPI.lua:158: Atlas_Refresh()
Atlas\Atlas.lua:845: func()
..\FrameXML\UIDropDownMenu.lua:568: UIDropDownMenuButton_OnClick()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
Last edited by TrAsHeR on Sat Nov 15, 2008 7:02 am, edited 1 time in total.

User avatar
Dan Gilbert
Developer
Posts: 2579
Joined: Sun Jan 29, 2006 10:24 pm
Location: Amherst, MA
Contact:

Re: Bug Transportation Maps

Post by Dan Gilbert » Fri Nov 14, 2008 5:23 pm

Ah. I removed the Location tags from the Transportation maps since they were completely redundant. The check in Atlas had to be changed very slightly from Location[1] to just Location. This probably has something to with the AL error. Basically, AL should check to see if Location exists, and then gracefully handle the case in which it doesn't. Prior to now, it was fine to assume it would be there; unlike the other tags, which could come and go.

Daviesh
Posts: 1315
Joined: Sat Jun 03, 2006 5:50 am
Location: Darwin, Australia
Contact:

Re: Bug Transportation Maps

Post by Daviesh » Fri Nov 14, 2008 8:39 pm

Yeah, whenever there is a core change in Atlas, I have to cut + paste the change into AtlasLoot (usually just changing variable names). The downside is that this breaks compatibility with the main version of Atlas everyone is using now.

User avatar
Dan Gilbert
Developer
Posts: 2579
Joined: Sun Jan 29, 2006 10:24 pm
Location: Amherst, MA
Contact:

Re: Bug Transportation Maps

Post by Dan Gilbert » Fri Nov 14, 2008 9:54 pm

Daviesh wrote:Yeah, whenever there is a core change in Atlas, I have to cut + paste the change into AtlasLoot (usually just changing variable names). The downside is that this breaks compatibility with the main version of Atlas everyone is using now.
Are you sure? I think changing the Location[1] check to Location would still work with 1.12.3, but I'm not positive.

Daviesh
Posts: 1315
Joined: Sat Jun 03, 2006 5:50 am
Location: Darwin, Australia
Contact:

Re: Bug Transportation Maps

Post by Daviesh » Sat Nov 15, 2008 4:26 am

You were right, simple fix, easily done. In the latest AtlasLoot SVN build. To check the fix just delete the '[1]' from line 158 of HooksandAPI.lua

User avatar
Dan Gilbert
Developer
Posts: 2579
Joined: Sun Jan 29, 2006 10:24 pm
Location: Amherst, MA
Contact:

Re: Bug Transportation Maps

Post by Dan Gilbert » Sat Nov 15, 2008 5:50 am

:D

TrAsHeR
Posts: 100
Joined: Tue Jan 09, 2007 1:53 am

Re: Bug Transportation Maps

Post by TrAsHeR » Sat Nov 15, 2008 7:01 am

Bug Fix for me :)

Post Reply